Add inching, indicator mode, fix dp in timer device#12105
Add inching, indicator mode, fix dp in timer device#12105Koenkk merged 21 commits intoKoenkk:masterfrom
Conversation
Removed 'CRITICAL:' from comment for clarity.
ohadvano
changed the title
ohadvano
changed the title
| 19, | ||
| "inching", | ||
| { | ||
| from: (value) => { |
There was a problem hiding this comment.
The logic for inching must be put in the lib, so other devices can re-use it.
And there already is tuya.valueConverter.inchingSwitch - can you check if that works?
There was a problem hiding this comment.
What I added is a different definition than the existing one. What I added behaves similar to how the Tuya app exposes inching, so no
There was a problem hiding this comment.
I think it's good to move this into lib/tuya.ts as inchingSwitch2
| e.enum("indicator_mode", ea.STATE_SET, ["none", "relay", "pos"]).withDescription("Indicator status behavior"), | ||
| e.binary("backlight_mode", ea.STATE_SET, "ON", "OFF").withDescription("Backlight"), | ||
| e.enum("off_color", ea.STATE_SET, ["red", "blue", "green", "white", "yellow", "magenta", "cyan"]).withDescription("OFF Color"), | ||
| e |
There was a problem hiding this comment.
te.inchingSwitch() should work ?
There was a problem hiding this comment.
no, see other comment
|
thanks for the review, the definition I added is a separate one that matches how Tuya app exposes inching so current definition can't be reused |
Removed inchingSwitch2 configuration from tuya.
Removed inching configuration and its value converter from the Tuya device integration.
Removed unnecessary comments regarding TypeScript type casting.
|
@Koenkk is this ready for merging? |
|
Thanks! |
3 participants
Link to picture pull request: TODO